[PATCH v2 1/2] drm/fsl-dcu: Add HDMI driver for freescale DCU

[Meng Yi]

Hi Stefan,

Thank for your reply.

> I took a bit more time to understand what it is all about with this patchset and
> the DRM bridge infrastructure in general.
> 
> I agree with Boris Brezillions comment of the first version of this
> patchset: You "only" want to add DRM bridge support here, it doesn't has
> anything to do with HDMI. So there should not be a file called
> fsl_dcu_drm_hdmi.c for instance....
> 
> In fact, you should fold the DRM bridge code into fsl_dcu_drm_rgb.c.
> Have a look at Boris patch which added such support to the Atmel HLDCD
> driver:
> https://lists.freedesktop.org/archives/dri-devel/2016-January/098050.html
> 
> However, the HLDCD driver already supported the endpoint syntax for panels
> at that time, which is not the case for the DCU driver.
> 
> Panel support with endpoint DT syntax seems to be more generic and is a
> easier first step towards DRM bridge support. Hence I suggest to take this two
> steps:
> 
> 1. Extend the current code to support panels through endpoint syntax
> (of_graph..)
> 2. Extend the endpoint support to also support DRM bridges
> 
> During 1 you should be careful to not remove the old fsl,panel support
> (backward compatibility). But it shouldn't be a big deal, just check if the
> fsl,panel property is there, if it is, do not parse the endpoints.
> Such backward compatibility has been implemented here:
> https://patchwork.kernel.org/patch/7706481/
> 

That's more reasonable. Thank much for your information and guidance!
I will working on that and send the patch later.

Best Regards,
Meng Yi