[PATCH] drm/omapdrm: don't call drm_helper_disable_unused_functions

[Daniel Vetter]

On Fri, Jun 10, 2016 at 09:26:42AM +0300, Tomi Valkeinen wrote:
> On 10/06/16 09:24, Tomi Valkeinen wrote:
> > On 10/06/16 01:14, Daniel Vetter wrote:
> >> It's a legacy helper function which won't do good with atomic helpers.
> >>
> >> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> >> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> >> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> >> ---
> >>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 3 ---
> >>  1 file changed, 3 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> >> index 31dfa0893416..adb10fbe918d 100644
> >> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> >> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> >> @@ -279,9 +279,6 @@ struct drm_fb_helper *omap_fbdev_init(struct drm_device *dev)
> >>  	if (ret)
> >>  		goto fini;
> >>  
> >> -	/* disable all the possible outputs/crtcs before entering KMS mode */
> >> -	drm_helper_disable_unused_functions(dev);
> >> -
> >>  	ret = drm_fb_helper_initial_config(helper, 32);
> >>  	if (ret)
> >>  		goto fini;
> >>
> > 
> > Acked-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> 
> Ops, my mail client was too eager to send this... I was about to ask if
> I should pick this up?

Sorry for the long delay. I merged this into drm-misc so that I can merge
the patch to WARN_ON when using this function for atomic drivers, too. Too
many people hit this little snag ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch