[PATCH 02/10] drm: Don't compute obj counts expensively in get_resources
Daniel Vetter
daniel at ffwll.ch
Tue Jun 21 12:21:14 UTC 2016
On Tue, Jun 21, 2016 at 10:48:08AM +0100, Chris Wilson wrote:
> On Tue, Jun 21, 2016 at 11:10:27AM +0200, Daniel Vetter wrote:
> > And to avoid surprising userspace, make sure we don't copy more
> > connectors than planned, and report the actual number of connectors
> > copied. That way any racing hot-add/remove will be handled.
>
> > @@ -1938,6 +1929,7 @@ int drm_mode_getresources(struct drm_device *dev, void *data,
> > }
> > copied++;
> > }
> > + connector_count = copied;
>
> You forgot to actually make sure we don't copy more conectors than
> planned.
Indeed, must have lost that hunk somewhere. At least I'm sure I've typed
it ;-) Will resend.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list