[PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time

Frank Binns frank.binns at imgtec.com
Mon Jun 27 09:37:54 UTC 2016


On 24/06/16 23:08, Alex Deucher wrote:
> On Fri, Jun 24, 2016 at 1:15 PM, Frank Binns <frank.binns at imgtec.com> wrote:
>> This flag was being set unconditionally at runtime so just set it at
>> compile time instead.
>>
>> Signed-off-by: Frank Binns <frank.binns at imgtec.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
> Do you want to take this as part of the patch set, or should I apply
> this to my tree?
>
> Alex

This patch is independent of the rest so I'm happy for you to
apply it to your tree.

Thanks
Frank

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index f888c01..7fe7f3c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -515,7 +515,7 @@ static struct drm_driver kms_driver = {
>>          .driver_features =
>>              DRIVER_USE_AGP |
>>              DRIVER_HAVE_IRQ | DRIVER_IRQ_SHARED | DRIVER_GEM |
>> -           DRIVER_PRIME | DRIVER_RENDER,
>> +           DRIVER_PRIME | DRIVER_RENDER | DRIVER_MODESET,
>>          .dev_priv_size = 0,
>>          .load = amdgpu_driver_load_kms,
>>          .open = amdgpu_driver_open_kms,
>> @@ -590,7 +590,6 @@ static int __init amdgpu_init(void)
>>          DRM_INFO("amdgpu kernel modesetting enabled.\n");
>>          driver = &kms_driver;
>>          pdriver = &amdgpu_kms_pci_driver;
>> -       driver->driver_features |= DRIVER_MODESET;
>>          driver->num_ioctls = amdgpu_max_kms_ioctl;
>>          amdgpu_register_atpx_handler();
>>          /* let modprobe override vga console setting */
>> --
>> 2.7.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel



More information about the dri-devel mailing list