[PATCH 1/5] drm: Unexport drm_connector_register_all()

[Chris Wilson]

On Mon, Jun 27, 2016 at 04:03:23PM +0300, Jani Nikula wrote:
> On Fri, 24 Jun 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > This has now been removed from all drivers as it is performed centrally
> > as a part of device registration for modesetting drivers. With the last
> > user gone, we can unexport it from the DRM module.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: dri-devel at lists.freedesktop.org
> > ---
> >  drivers/gpu/drm/drm_crtc.c | 19 +------------------
> >  include/drm/drm_crtc.h     |  1 -
> >  2 files changed, 1 insertion(+), 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 1190638a3d53..c660ea28cf26 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -1109,23 +1109,7 @@ void drm_connector_unregister(struct drm_connector *connector)
> >  }
> >  EXPORT_SYMBOL(drm_connector_unregister);
> >  
> > -/**
> > - * drm_connector_register_all - register all connectors
> > - * @dev: drm device
> > - *
> > - * This function registers all connectors in sysfs and other places so that
> > - * userspace can start to access them. drm_connector_register_all() is called
> > - * automatically from drm_dev_register() to complete the device registration,
> 
> Bikeshed, why throw away the documentation when you could just tweak it
> to reflect reality?

Because Daniel only wanted the public interface in the DRM docs to avoid
confusion. Drivers should only be calling drm_connector_register to
handle dynamic configuration changes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre