[PATCH 3/4] drm: bridge/dw-hdmi: detect initial connector state

Thierry Reding thierry.reding at gmail.com
Wed Mar 2 16:35:54 UTC 2016


On Fri, Jan 08, 2016 at 10:02:06AM +0100, Philipp Zabel wrote:
> Allow userspace to read the initial connector state via sysfs without
> having to issue a detect manually. There is no reason to keep the state
> unknown during initialization.
> 
> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> ---
>  drivers/gpu/drm/bridge/dw-hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)

It would seem to me that this should be the default, rather than having
to duplicate this into every driver.

Daniel, can you think of a reason why we wouldn't want to do handle this
in the core so that all drivers can benefit?

Thierry

> 
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index e41ff4b..2388a55 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1660,6 +1660,8 @@ static int dw_hdmi_register(struct drm_device *drm, struct dw_hdmi *hdmi)
>  				   DRM_MODE_CONNECTOR_HDMIA);
>  
>  	hdmi->connector.encoder = encoder;
> +	hdmi->connector.status = dw_hdmi_connector_detect(&hdmi->connector,
> +							  false);
>  
>  	drm_mode_connector_attach_encoder(&hdmi->connector, encoder);
>  
> -- 
> 2.6.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160302/d00fdee9/attachment.sig>


More information about the dri-devel mailing list