[PATCH] staging/android: add flags member to sync ioctl structs

Gustavo Padovan gustavo at padovan.org
Thu Mar 3 19:42:28 UTC 2016


2016-03-03 Gustavo Padovan <gustavo.padovan at collabora.co.uk>:

> Hi Greg,
> 
> 2016-03-03 Greg Kroah-Hartman <gregkh at linuxfoundation.org>:
> 
> > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote:
> > > From: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
> > > 
> > > Play safe and add flags member to all structs. So we don't need to
> > > break API or create new IOCTL in the future if new features that requires
> > > flags arises.
> > > 
> > > v2: check if flags are valid (zero, in this case)
> > > 
> > > v3: return -EINVAL if flags are not zero'ed
> > > 
> > > v4: add padding for 64-bit alignment
> > > 
> > > v5: rebase to use only stacked sync_file_info
> > 
> > Why are these vX things here in the changelog?
> 
> There are few people who does this in drm, so I just followed that.  

Anyway, I've sent v7 without the vX things in the changelog.

	Gustavo


More information about the dri-devel mailing list