[PATCH 02/42] drm/omap: move dss_suspend/resume_all to core.c

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Monday 22 February 2016 19:10:08 Tomi Valkeinen wrote:
> core.c is the only caller of dss_disable_all_devices(). We can thus move
> the function from display.c to core.c and make it static.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/core.c    | 13 +++++++++++++
>  drivers/gpu/drm/omapdrm/dss/display.c | 13 -------------
>  drivers/gpu/drm/omapdrm/dss/dss.h     |  2 --
>  3 files changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/core.c
> b/drivers/gpu/drm/omapdrm/dss/core.c index 1f55d0aae03d..7e4e5bebabbe
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/core.c
> +++ b/drivers/gpu/drm/omapdrm/dss/core.c
> @@ -166,6 +166,19 @@ int dss_debugfs_create_file(const char *name, void
> (*write)(struct seq_file *))
> 
>  /* PLATFORM DEVICE */
> 
> +static void dss_disable_all_devices(void)
> +{
> +	struct omap_dss_device *dssdev = NULL;
> +
> +	for_each_dss_dev(dssdev) {
> +		if (!dssdev->driver)
> +			continue;
> +
> +		if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> +			dssdev->driver->disable(dssdev);
> +	}
> +}
> +
>  static int __init omap_dss_probe(struct platform_device *pdev)
>  {
>  	struct omap_dss_board_info *pdata = pdev->dev.platform_data;
> diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
> b/drivers/gpu/drm/omapdrm/dss/display.c index 24c2bffa0036..9f3dd09b0a6c
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/display.c
> +++ b/drivers/gpu/drm/omapdrm/dss/display.c
> @@ -78,19 +78,6 @@ void omapdss_default_get_timings(struct omap_dss_device
> *dssdev, }
>  EXPORT_SYMBOL(omapdss_default_get_timings);
> 
> -void dss_disable_all_devices(void)
> -{
> -	struct omap_dss_device *dssdev = NULL;
> -
> -	for_each_dss_dev(dssdev) {
> -		if (!dssdev->driver)
> -			continue;
> -
> -		if (dssdev->state == OMAP_DSS_DISPLAY_ACTIVE)
> -			dssdev->driver->disable(dssdev);
> -	}
> -}
> -
>  static LIST_HEAD(panel_list);
>  static DEFINE_MUTEX(panel_list_mutex);
>  static int disp_num_counter;
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h
> b/drivers/gpu/drm/omapdrm/dss/dss.h index a974d46672db..56ce89d4be27 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.h
> @@ -206,8 +206,6 @@ int dss_set_min_bus_tput(struct device *dev, unsigned
> long tput); int dss_debugfs_create_file(const char *name, void
> (*write)(struct seq_file *));
> 
>  /* display */
> -void dss_disable_all_devices(void);
> -
>  int display_init_sysfs(struct platform_device *pdev);
>  void display_uninit_sysfs(struct platform_device *pdev);

-- 
Regards,

Laurent Pinchart