linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c: 5 * uninit data ?

[David Binderman]

Hello there,

[linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c:175]: (error) Uninitialized struct member: clock.dot
[linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c:175]: (error) Uninitialized struct member: clock.m1
[linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c:175]: (error) Uninitialized struct member: clock.m2
[linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c:175]: (error) Uninitialized struct member: clock.p2
[linux-4.5/drivers/gpu/drm/gma500/oaktrail_crtc.c:175]: (error) Uninitialized struct member: clock.vco

Source code is

                    *best_clock = clock;

Suggest init all fields of local variable clock shortly after declaration, that
way the function mrst_sdvo_find_best_pll can only ever return init'ed data.

Regards

David Binderman