[PATCH] drm/atmel: Fixup drm_connector_/unplug/unregister/_all

[Daniel Vetter]

On Tue, Mar 29, 2016 at 12:25:55PM +0000, Alexey Brodkin wrote:
> Hi Daniel,
> 
> On Tue, 2016-03-29 at 14:21 +0200, Daniel Vetter wrote:
> > Accidentally fell through the cracks in
> > 
> > commit 6c87e5c3ec6db052f3744804a517b6fb003906e1
> > Author: Alexey Brodkin <Alexey.Brodkin at synopsys.com>
> > Date:   Wed Mar 23 11:42:54 2016 +0300
> > 
> >     drm: Rename drm_connector_unplug_all() to drm_connector_unregister_all()
> > 
> > despite that Boris acked that patch.
> > 
> > Cc: Boris Brezillon <boris.brezillon at free-electrons.com>
> > Cc: Alexey Brodkin <abrodkin at synopsys.com>
> > Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> > Reported-by: kbuild test robot <fengguang.wu at intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > index 3d8d16402d07..8ab4318e57a1 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
> > @@ -615,7 +615,7 @@ err:
> >  static void atmel_hlcdc_dc_connector_unplug_all(struct drm_device *dev)
> >  {
> >  	mutex_lock(&dev->mode_config.mutex);
> > -	drm_connector_unplug_all(dev);
> > +	drm_connector_unregister_all(dev);
> >  	mutex_unlock(&dev->mode_config.mutex);
> >  }
> 
> Isn't done in my "[PATCH 2/3 v5] drm: atmel_hldc: Use generic drm_connector_register_all() helper"?

Yes, but splitting it like that breaks bisectability, which isn't good.
Also your atmel change drops the mode_config.mutex. We might want to have
that part in a separate patch, so that the atmel patch only switches over
to the register_all helper.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch