[PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path
Philipp Zabel
p.zabel at pengutronix.de
Wed Mar 30 13:35:23 UTC 2016
Hi Doug,
Am Montag, den 28.03.2016, 08:14 -0700 schrieb Doug Anderson:
> Hi,
>
> On Mon, Mar 7, 2016 at 2:00 PM, Douglas Anderson <dianders at chromium.org> wrote:
> > The drm_encoder_cleanup() was missing both from the error path of
> > dw_hdmi_imx_bind(). This caused a crash when slub_debug was
> > enabled and we ended up deferring probe of HDMI at boot.
> >
> > This call isn't needed from unbind() because if dw_hdmi_bind() returns
> > no error then it takes over the job of freeing the encoder (in
> > dw_hdmi_unbind).
> >
> > Signed-off-by: Douglas Anderson <dianders at chromium.org>
> > ---
> > Changes in v2:
> > - IMX patch new in v2
> >
> > drivers/gpu/drm/imx/dw_hdmi-imx.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
>
> Mark picked up:
>
> [PATCH v2 1/5] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path
> [PATCH v2 3/5] drm/rockchip: vop: Fix vop crtc cleanup
> [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()
>
> ...for Rockchip, as you can see at
> <https://patchwork.kernel.org/patch/8523301/>.
>
> Does someone want to pick up:
> [PATCH v2 2/5] drm/imx: dw_hdmi: Call drm_encoder_cleanup() in error path
> [PATCH v2 5/5] drm/imx: dw_hdmi: Don't call platform_set_drvdata()
>
> Thanks!
Thank you for the reminder, both patches applied.
regards
Philipp
More information about the dri-devel
mailing list