[PATCH 2/2] drm/etnaviv: fix mmap operations for userptr and dma-buf objects

Lucas Stach l.stach at pengutronix.de
Mon May 2 11:09:23 UTC 2016


Am Mittwoch, den 27.04.2016, 21:27 +0100 schrieb Russell King - ARM
Linux:
> On Wed, Apr 27, 2016 at 02:39:21PM +0200, Lucas Stach wrote:
> > +static int etnaviv_gem_userptr_mmap_obj(struct etnaviv_gem_object *etnaviv_obj,
> > +		struct vm_area_struct *vma)
> > +{
> > +	return -EPERM;
> > +}
> 
>        EPERM  The prot argument asks for PROT_EXEC but the mapped area belongs
>               to a file on a file system that was mounted no-exec.
> 
> It seems this error code is not suitable for this application - it
> doesn't fit the spirit of EPERM.  The universal EINVAL would probably
> be better.
> 
I've changed this to return EINVAL.

Regards,
Lucas



More information about the dri-devel mailing list