[PATCH v3 1/2] drm: bridge: Add sii902x driver

Daniel Vetter daniel at ffwll.ch
Tue May 3 09:53:18 UTC 2016


On Tue, May 3, 2016 at 11:39 AM, Boris Brezillon
<boris.brezillon at free-electrons.com> wrote:
>> > +   .detect = sii902x_connector_detect,
>> > +   .fill_modes = drm_helper_probe_single_connector_modes,
>> > +   .destroy = sii902x_connector_destroy,
>> > +};
>>
>> I'm guessing this is to support both atomic and !atomic drivers. I
>> thought it was working automatically?
>
> Hm, the dw-hdmi driver is providing both, but maybe it's not needed.
> Daniel, any comments?

You only need this in case you actually have atomic and !atomic users
of your bridge. We discussed whether we should have a dpms helper that
dtrt automatically, but with just 1 driver that doesn't seem worth it.
You wouldn't need to have 2 entier vfunc tables, you could just switch
on DRIVER_ATOMIC.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list