[PATCH] drm/hisilicon: Use drm_connector_register_all

Chris Wilson chris at chris-wilson.co.uk
Fri May 6 08:37:25 UTC 2016


On Fri, May 06, 2016 at 10:28:41AM +0200, Daniel Vetter wrote:
> Also, the unbind function is totally not sufficient, and it's calling
> the deprecated drm_put_dev.

diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 360b2a74e1ef..7efc0b477e38 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1032,7 +1032,7 @@ extern void drm_vblank_post_modeset(struct drm_device *dev, unsigned int pipe);
 extern struct drm_master *drm_master_get(struct drm_master *master);
 extern void drm_master_put(struct drm_master **master);
 
-extern void drm_put_dev(struct drm_device *dev);
+__deprecated extern void drm_put_dev(struct drm_device *dev);
 extern void drm_unplug_dev(struct drm_device *dev);
 extern unsigned int drm_debug;
 extern bool drm_atomic;

And you probably should markup all the others that are now deprecated and
being phased out.

Maybe behind drm_deprecated so that the spam is hidden behind another
kconfig option rather than enabled-by-buildbots?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list