[PATCH 2/2] drm/sti: include linux/seq_file.h where needed

[Daniel Vetter]

On Wed, May 11, 2016 at 09:07:06AM +0200, Benjamin Gaignard wrote:
> Acked-by: Benjamin Gaignard <benjamin.gaignard at linaro.org>
> 
> 2016-05-09 23:51 GMT+02:00 Arnd Bergmann <arnd at arndb.de>:
> > The sti drm driver has a lot of debugfs interface that cause
> > build errors in some configurations when seq_file.h is not
> > included implicitly:
> >
> > drm/sti/sti_mixer.c: In function 'mixer_dbg_ctl':
> > drm/sti/sti_mixer.c:88:2: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
> > drm/sti/sti_mixer.c:91:4: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> > drm/sti/sti_gdp.c: In function 'gdp_dbg_ctl':
> > drm/sti/sti_gdp.c:146:2: error: implicit declaration of function 'seq_puts' [-Werror=implicit-function-declaration]
> > drm/sti/sti_gdp.c:149:4: error: implicit declaration of function 'seq_printf' [-Werror=implicit-function-declaration]
> > drm/sti/sti_gdp.c: In function 'gdp_dbg_show':
> > drm/sti/sti_gdp.c:208:32: error: dereferencing pointer to incomplete type 'struct seq_file'
> >
> > This adds an explicit #include statement in all of the affected files.
> >
> > Signed-off-by: Arnd Bergmann <arnd at arndb.de>

Applied to drm-misc.
-Daniel

> > ---
> >  drivers/gpu/drm/sti/sti_cursor.c | 2 ++
> >  drivers/gpu/drm/sti/sti_gdp.c    | 1 +
> >  drivers/gpu/drm/sti/sti_hda.c    | 1 +
> >  drivers/gpu/drm/sti/sti_hqvdp.c  | 1 +
> >  drivers/gpu/drm/sti/sti_mixer.c  | 1 +
> >  drivers/gpu/drm/sti/sti_tvout.c  | 1 +
> >  drivers/gpu/drm/sti/sti_vid.c    | 1 +
> >  7 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c
> > index 3abb400151ac..4e990299735c 100644
> > --- a/drivers/gpu/drm/sti/sti_cursor.c
> > +++ b/drivers/gpu/drm/sti/sti_cursor.c
> > @@ -6,6 +6,8 @@
> >   * License terms:  GNU General Public License (GPL), version 2
> >   */
> >
> > +#include <linux/seq_file.h>
> > +
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_fb_cma_helper.h>
> >  #include <drm/drm_gem_cma_helper.h>
> > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
> > index ff3d3e7e7704..ff33c38da197 100644
> > --- a/drivers/gpu/drm/sti/sti_gdp.c
> > +++ b/drivers/gpu/drm/sti/sti_gdp.c
> > @@ -5,6 +5,7 @@
> >   *          for STMicroelectronics.
> >   * License terms:  GNU General Public License (GPL), version 2
> >   */
> > +#include <linux/seq_file.h>
> >
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_fb_cma_helper.h>
> > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
> > index ec0d017eaf1a..f7d3464cdf09 100644
> > --- a/drivers/gpu/drm/sti/sti_hda.c
> > +++ b/drivers/gpu/drm/sti/sti_hda.c
> > @@ -8,6 +8,7 @@
> >  #include <linux/component.h>
> >  #include <linux/module.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/seq_file.h>
> >
> >  #include <drm/drmP.h>
> >  #include <drm/drm_atomic_helper.h>
> > diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> > index e05b0dc523ff..1edec29b9e45 100644
> > --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> > +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> > @@ -7,6 +7,7 @@
> >  #include <linux/component.h>
> >  #include <linux/firmware.h>
> >  #include <linux/reset.h>
> > +#include <linux/seq_file.h>
> >
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_fb_cma_helper.h>
> > diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
> > index e7425c38fc93..aed7801b51f7 100644
> > --- a/drivers/gpu/drm/sti/sti_mixer.c
> > +++ b/drivers/gpu/drm/sti/sti_mixer.c
> > @@ -5,6 +5,7 @@
> >   *          for STMicroelectronics.
> >   * License terms:  GNU General Public License (GPL), version 2
> >   */
> > +#include <linux/seq_file.h>
> >
> >  #include "sti_compositor.h"
> >  #include "sti_mixer.h"
> > diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> > index 2c99016443e5..f983db5a59da 100644
> > --- a/drivers/gpu/drm/sti/sti_tvout.c
> > +++ b/drivers/gpu/drm/sti/sti_tvout.c
> > @@ -12,6 +12,7 @@
> >  #include <linux/of_platform.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/reset.h>
> > +#include <linux/seq_file.h>
> >
> >  #include <drm/drmP.h>
> >  #include <drm/drm_crtc_helper.h>
> > diff --git a/drivers/gpu/drm/sti/sti_vid.c b/drivers/gpu/drm/sti/sti_vid.c
> > index 5a2c5dc3687b..523ed19f5ac6 100644
> > --- a/drivers/gpu/drm/sti/sti_vid.c
> > +++ b/drivers/gpu/drm/sti/sti_vid.c
> > @@ -3,6 +3,7 @@
> >   * Author: Fabien Dessenne <fabien.dessenne at st.com> for STMicroelectronics.
> >   * License terms:  GNU General Public License (GPL), version 2
> >   */
> > +#include <linux/seq_file.h>
> >
> >  #include <drm/drmP.h>
> >
> > --
> > 2.7.0
> >
> 
> 
> 
> -- 
> Benjamin Gaignard
> 
> Graphic Working Group
> 
> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro: Facebook | Twitter | Blog

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch