[PATCH v4 0/3] drm: Add various helpers for simple drivers

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu May 12 19:05:37 UTC 2016


Hi Noralf,

Thank you for the patches.

For 1/3 and 2/3,

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

On Thursday 12 May 2016 20:25:20 Noralf Trønnes wrote:
> This patchset adds various helpers that was originally part of the
> tinydrm patchset.
> 
> Essentially it adds 2 functions:
> - drm_fb_cma_create_with_funcs()
>   CMA backed framebuffer supporting a dirty() callback.
> - drm_simple_display_pipe_init()
>   Plane, crtc and encoder are collapsed into one entity.
> 
> 
> Changes since v3:
> - Add patch 'drm/fb-cma-helper: Use const for drm_framebuffer_funcs
> argument' - drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
>   - funcs argument should be const
> - drm: Add helper for simple display pipeline
>   - (struct drm_simple_display_pipe *)->funcs should be const
> 
> Changes since v2:
> - drm: Add helper for simple display pipeline
>   - Drop Kconfig knob DRM_KMS_HELPER
>   - Expand documentation
> 
> Changes since v1:
> - Drop patch: drm/panel: Add helper for simple panel connector
> - Add fb-helper and fb-cma-helper doc patches
> - Add drm/atomic: Don't skip drm_bridge_*() calls if
> !drm_encoder_helper_funcs - Add drm_atomic_helper_best_encoder()
> - drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
>   - Expand docs
> - drm: Add helper for simple display pipeline
>   - Add DOC header and add to gpu.tmpl
>   - Fix docs: @funcs is optional, "negative error code",
>     "This hook is optional."
>   - Add checks to drm_simple_kms_plane_atomic_check()
> 
> 
> Noralf Trønnes (3):
>   drm/fb-cma-helper: Use const for drm_framebuffer_funcs argument
>   drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs()
>   drm: Add helper for simple display pipeline
> 
>  Documentation/DocBook/gpu.tmpl          |   6 +
>  drivers/gpu/drm/Makefile                |   2 +-
>  drivers/gpu/drm/drm_fb_cma_helper.c     |  35 ++++--
>  drivers/gpu/drm/drm_simple_kms_helper.c | 208
> ++++++++++++++++++++++++++++++++ include/drm/drm_fb_cma_helper.h         | 
>  5 +-
>  include/drm/drm_simple_kms_helper.h     |  94 +++++++++++++++
>  6 files changed, 340 insertions(+), 10 deletions(-)
>  create mode 100644 drivers/gpu/drm/drm_simple_kms_helper.c
>  create mode 100644 include/drm/drm_simple_kms_helper.h
> 
> --
> 2.8.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list