[GIT PULL] imx-drm module autoloading fix

Philipp Zabel p.zabel at pengutronix.de
Tue May 17 10:51:02 UTC 2016


Am Dienstag, den 17.05.2016, 10:56 +0200 schrieb Philipp Zabel:
> Am Donnerstag, den 05.05.2016, 10:37 +1000 schrieb Dave Airlie:
> > On 3 May 2016 at 18:48, Philipp Zabel <p.zabel at pengutronix.de> wrote:
> > > Hi Dave,
> > >
> > > here is the imx-ipuv3-crtc autoloading fix so you don't have to revert commit
> > > 304e6be652e2 ("gpu: ipu-v3: Assign of_node of child platform devices to
> > > corresponding ports").
> > 
> > I didn't pull this, but I cherry-picked the patch out and added stable
> > tags on it
> > since Denis wanted to get it into 4.4 and above.
> 
> It turns out this patch breaks probing for the built-in case [1]. As a
> result, imx-drm probing is broken in v4.6. I have sent a patch [2] to
> fix the issue by matching the crtc components not against dev->of_node
> but against an of_node pointer stored in platform data.
> 
> [1] http://comments.gmane.org/gmane.linux.ports.arm.kernel/499839
>     Message-ID: <20160513123336.6996dd89 at ipc1.ka-ro>
> [2] https://patchwork.kernel.org/patch/9081661/
>     Message-ID: <1463062124-20256-1-git-send-email-p.zabel at pengutronix.de>
> 
> Could we apply that or revert commit 407c9eba7897 ("drm/imx: Remove
> of_node assignment from ipuv3-crtc driver probe") for the time being?
> 
> Either way, applying this patch without doing either of the two will
> break imx-drm probing in v4.4 and v4.5 stable, too.

I stand corrected, v4.4.10 and v4.5.4 are already broken, too.

regards
Philipp


More information about the dri-devel mailing list