[PATCH 07/14] drm/imx: atomic phase 2 step 1: Wire up state ->reset, ->duplicate and ->destroy

Philipp Zabel p.zabel at pengutronix.de
Tue May 24 14:23:44 UTC 2016


Am Dienstag, den 24.05.2016, 18:10 +0800 schrieb Liu Ying:
> Wire up CRTCs', planes' and connectors' ->reset, ->duplicate and ->destroy state
> hooks to use the default implementations from the atomic helper library.
> The helpers track each DRM object state.
> 
> Signed-off-by: Liu Ying <gnuiyl at gmail.com>
> ---
>  drivers/gpu/drm/bridge/dw-hdmi.c       | 19 +++----------------
>  drivers/gpu/drm/imx/imx-drm-core.c     |  2 ++
>  drivers/gpu/drm/imx/imx-ldb.c          |  4 ++++
>  drivers/gpu/drm/imx/imx-tve.c          |  4 ++++
>  drivers/gpu/drm/imx/ipuv3-crtc.c       |  4 ++++
>  drivers/gpu/drm/imx/ipuv3-plane.c      |  4 ++++
>  drivers/gpu/drm/imx/parallel-display.c |  4 ++++
>  7 files changed, 25 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c
> index 9795b72..6541b3c 100644
> --- a/drivers/gpu/drm/bridge/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/dw-hdmi.c
> @@ -1508,14 +1508,6 @@ static void dw_hdmi_connector_force(struct drm_connector *connector)
>  	mutex_unlock(&hdmi->mutex);
>  }
>  
> -static const struct drm_connector_funcs dw_hdmi_connector_funcs = {
> -	.dpms = drm_helper_connector_dpms,
> -	.fill_modes = drm_helper_probe_single_connector_modes,
> -	.detect = dw_hdmi_connector_detect,
> -	.destroy = dw_hdmi_connector_destroy,
> -	.force = dw_hdmi_connector_force,
> -};
> -
>  static const struct drm_connector_funcs dw_hdmi_atomic_connector_funcs = {

Might as well remove the _atomic_ form the structure's name.

regards
Philipp



More information about the dri-devel mailing list