[PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt()

Jyri Sarha jsarha at ti.com
Thu May 26 12:19:56 UTC 2016


On 05/26/16 13:17, Daniel Vetter wrote:
> On Thu, May 26, 2016 at 11:35:44AM +0300, Jyri Sarha wrote:
>> > Implements gamma tables for OMAP4, OMAP5, and dra7xx SoCs and adds a
>> > workaround for errata that may break LCD1 channel if gamma tables
>> > are in use.
>> >
>> > Also adds new drm_crtc_enable_color_mgmt() as suggested[1] by Daniel
>> > Vetter and get rid of the old drm_helper_crtc_enable_color_mgmt(). I
>> > have not tested the change to i915 driver, only compiled it, but
>> > functionally it should be exactly the same.
>> >
>> > [1] http://www.spinics.net/lists/dri-devel/msg108092.html
> Btw for testing it would be awesome if you could take the color manager
> igt testcase we have, and make it generic. Probably needs some
> adjustments like skip tests when not all properties which are needed are
> there. We should already auto-skip crc-based tests when that's not there,
> so hopefully not too much work.
> 
> This way we could start to have something like real validation tests for
> all these atomic extensions and make sure things do work across drivers in
> a uniform way. Tomeu and Robert have done this conversion work thus far,
> with Daniel leading the effort (all cc'ed). Lionel has done the color mgmt
> test.


Well, the igt is totally new to me. I could take a look after our next
internal release in 2-3 weeks from now.

But, how about this series? Should I send a pull request directly to
Dave Airlie to get this in drm-next?

BR,
Jyri




More information about the dri-devel mailing list