[PATCH 1/2] Revert "drm: Add and handle new aspect ratios in DRM layer"

[Daniel Vetter]

On Fri, Nov 11, 2016 at 6:07 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
>> This was with sna, which does this:
>>  #define KNOWN_MODE_FLAGS ((1<<14)-1)
>>  if (mode->status == MODE_OK && kmode->flags & ~KNOWN_MODE_FLAGS)
>>         mode->status = MODE_BAD; /* unknown flags => unhandled */
>> so all the modes with an aspect ratio just vanished.
>>
>> -modesetting and -ati on the other hand just copy over the unknown
>> bits into the xrandr mode structure, which sounds dubious at best:
>>  mode->Flags = kmode->flags; //& FLAG_BITS;
>> I've not checked what damage it can actually cause.
>
> What problems could this cause?  Presumably the kernel driver has
> validated the modes already or they wouldn't showing up in the first
> place.  Or is your concern that something in the xserver itself may
> barf on the new flags?

See above snipped from sna, we now lost a bunch of modes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch