[PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops

[Stefan Christ]

Hi Christian,

On Mon, Nov 14, 2016 at 10:43:10AM +0100, Christian König wrote:
> Am 14.11.2016 um 00:03 schrieb Stefan Christ:
> > Hi,
> >
> > this is the second version of the refactoring work suggested by Daniel Vetter
> > in the email:
> >
> >     https://lists.freedesktop.org/archives/dri-devel/2016-July/113237.html
> >
> > The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> > implementations for functions in struct fb_ops. A drm driver can use it like:
> >
> >      static struct fb_ops drm_fbdev_cma_ops = {
> >          .owner          = THIS_MODULE,
> >          DRM_FB_HELPER_DEFAULT_OPS,
> >          /* driver specific implementations */
> >      };
> 
> Looks good to me in general, but I've got one question. Why didn't you 
> put the owner field into the macro as well?
> 
> I have strong doubts that anybody would set anything else than 
> THIS_MODULE here.
> 

In the initial suggestion by Daniel Vetter he also mentioned this
possibility. See email and response:

    https://lists.freedesktop.org/archives/dri-devel/2016-July/114136.html

But I decided against it, since it hides even more magic behind the
helper define.

Mit freundlichen Grüßen / Kind regards,
	Stefan Christ