[PATCH] drm/fb_cma_helper: Add missing forward declaration

Daniel Vetter daniel at ffwll.ch
Tue Nov 15 11:24:24 UTC 2016


On Tue, Nov 15, 2016 at 11:55:29AM +0100, Marek Vasut wrote:
> Add missing forward declaration for struct drm_plane and drm_plane_state,
> which causes the following warning in the VC4 driver (can be replicated
> by building using bcm2835_defconfig):
> 
> In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
> include/drm/drm_fb_cma_helper.h:45:13: warning: ‘struct drm_plane_state’ declared inside parameter list will not be visible outside of this definition or declaration
>       struct drm_plane_state *state);
>              ^~~~~~~~~~~~~~~
> include/drm/drm_fb_cma_helper.h:44:34: warning: ‘struct drm_plane’ declared inside parameter list will not be visible outside of this definition or declaration
>  int drm_fb_cma_prepare_fb(struct drm_plane *plane,
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>

Applied to drm-misc, thx for the quick fixup.
-Daniel

> ---
>  include/drm/drm_fb_cma_helper.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
> index cc82c73..3b00f64 100644
> --- a/include/drm/drm_fb_cma_helper.h
> +++ b/include/drm/drm_fb_cma_helper.h
> @@ -12,6 +12,8 @@ struct drm_fb_helper;
>  struct drm_device;
>  struct drm_file;
>  struct drm_mode_fb_cmd2;
> +struct drm_plane;
> +struct drm_plane_state;
>  
>  struct drm_fbdev_cma *drm_fbdev_cma_init_with_funcs(struct drm_device *dev,
>  	unsigned int preferred_bpp, unsigned int num_crtc,
> -- 
> 2.10.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list