[drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration

[Marek Vasut]

On 11/15/2016 11:02 AM, Daniel Vetter wrote:
> On Tue, Nov 15, 2016 at 09:47:31AM +0100, Daniel Vetter wrote:
>> On Tue, Nov 15, 2016 at 04:29:04PM +0800, kbuild test robot wrote:
>>> tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
>>> head:   35cf03508d8466ecc5199c9d609e74e85bec785b
>>> commit: 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29 [23/26] drm/fb_cma_helper: Add drm_fb_cma_prepare_fb() helper
>>> config: i386-allmodconfig (attached as .config)
>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>> reproduce:
>>>         git checkout 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29
>>>         # save the attached .config to linux build tree
>>>         make ARCH=i386 
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>    In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
>>>>> include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
>>>          struct drm_plane_state *state);
>>>                 ^~~~~~~~~~~~~~~
>>>>> include/drm/drm_fb_cma_helper.h:44:34: warning: 'struct drm_plane' declared inside parameter list will not be visible outside of this definition or declaration
>>>     int drm_fb_cma_prepare_fb(struct drm_plane *plane,
>>>                                      ^~~~~~~~~
>>
>> Oops, didn't noticed this compiler warning before pushing. Since drm-misc
>> is non-rebasing, can you pls supply a full fixup patch Marek?
> 
> Probably just need an #include <drm/drm_plane.h> in drm_fb_cma_helper.h.

Actually, just a forward declaration of the struct drm_plane and
drm_plane_state is what is needed, it's already done for the other
structures there. Patch is coming.

-- 
Best regards,
Marek Vasut