[PATCH 13/32] drm: Pass 'dev' to drm_helper_mode_fill_fb_struct()

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Nov 17 17:41:49 UTC 2016


Hi Ville,

Thank you for the patch.

On Thursday 17 Nov 2016 18:14:12 ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Pass the drm_device to drm_helper_mode_fill_fb_struct() so that we can
> populate fb->dev early. Will make it easier to use the fb before we
> register it.
> 
> @@
> identifier fb, mode_cmd;
> @@
>  void drm_helper_mode_fill_fb_struct(
> +				     struct drm_device *dev,
> 				     struct drm_framebuffer *fb,
> 				     const struct drm_mode_fb_cmd2 *mode_cmd
> 				     );
> 
> @@
> identifier fb, mode_cmd;
> @@
>  void drm_helper_mode_fill_fb_struct(
> +				     struct drm_device *dev,
> 				     struct drm_framebuffer *fb,
> 				     const struct drm_mode_fb_cmd2 *mode_cmd
> 				     )
> { ... }
> 
> @@
> function func;
> identifier dev;
> expression E1, E2;
> @@
> func(struct drm_device *dev, ...)
> {
>  ...
>  drm_helper_mode_fill_fb_struct(
> +				dev,
> 				E1, E2);
>  ...
> }

Just for the tegra driver :-)

> @@
> expression E1, E2;
> @@
>  drm_helper_mode_fill_fb_struct(
> +				dev,
> 				E1, E2);
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
>  drivers/gpu/drm/armada/armada_fb.c          | 2 +-
>  drivers/gpu/drm/ast/ast_main.c              | 2 +-
>  drivers/gpu/drm/bochs/bochs_mm.c            | 2 +-
>  drivers/gpu/drm/cirrus/cirrus_main.c        | 2 +-
>  drivers/gpu/drm/drm_fb_cma_helper.c         | 2 +-
>  drivers/gpu/drm/drm_modeset_helper.c        | 3 ++-
>  drivers/gpu/drm/exynos/exynos_drm_fb.c      | 2 +-
>  drivers/gpu/drm/gma500/framebuffer.c        | 2 +-
>  drivers/gpu/drm/i915/intel_display.c        | 2 +-
>  drivers/gpu/drm/mediatek/mtk_drm_fb.c       | 2 +-
>  drivers/gpu/drm/mgag200/mgag200_main.c      | 2 +-
>  drivers/gpu/drm/msm/msm_fb.c                | 2 +-
>  drivers/gpu/drm/nouveau/nouveau_display.c   | 2 +-
>  drivers/gpu/drm/omapdrm/omap_fb.c           | 2 +-
>  drivers/gpu/drm/qxl/qxl_display.c           | 2 +-
>  drivers/gpu/drm/radeon/radeon_display.c     | 2 +-
>  drivers/gpu/drm/rockchip/rockchip_drm_fb.c  | 2 +-
>  drivers/gpu/drm/tegra/fb.c                  | 2 +-
>  drivers/gpu/drm/udl/udl_fb.c                | 2 +-
>  drivers/gpu/drm/virtio/virtgpu_display.c    | 2 +-
>  include/drm/drm_modeset_helper.h            | 3 ++-
>  22 files changed, 24 insertions(+), 22 deletions(-)

-- 
Regards,

Laurent Pinchart



More information about the dri-devel mailing list