[PATCHv3 3/4] drm/tilcdc: Use unload to handle initialization failures

Bartosz Golaszewski bgolaszewski at baylibre.com
Fri Nov 18 16:57:56 UTC 2016


2016-11-02 16:57 GMT+01:00 Jyri Sarha <jsarha at ti.com>:
> Use unload to handle initialization failures instead of complex goto
> label mess. To do this the initialization sequence needed slight
> reordering and some unload functions needed to become conditional.
>
> Signed-off-by: Jyri Sarha <jsarha at ti.com>
> ---

I'm not sure yet of the exact error path, but with this patch
tilcdc_crtc_destroy() fails with a NULL-pointer dereference at
dmam_free_coherent() due to crtc->dev being NULL if there are no
panels registered.

Thanks,
Bartosz Golaszewski


More information about the dri-devel mailing list