[PATCH v3 02/11] drm/tilcdc: implement palette loading for rev1

[Jyri Sarha]

On 11/24/16 11:43, Tomi Valkeinen wrote:
> What is the difference? If mode changes, you need to disable and enable
> the crtc, right? What other cases there are to enable the display? After
> blank? Then the display has been off, and I presume palette has to be
> loaded.

At the moment the palette or register values do not appear to vanish
ever. But that is probably due to PM not doing much to optimize the LCDC
power consumption.

Anyway, if simple enable is enough to turn on the display - all video
timings, frame buffer dma addresses etc. are already in the registers -
then I think it is safe to assume that the palette is still in there too.

Then it is a different issue, that I should probably put the same
functionality into PM runtime_suspend() and runtime_resume() callbacks,
that is currently in suspend() and resume() callbacks, to be ready if PM
ever does anything more for LCDC that it does today. I could of course
add a test if the registers are still intact before doing a restore.

BR,
Jyri

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161124/e58a4704/attachment.sig>