[PATCH] drm/atomic: Constify drm_atomic_crtc_needs_modeset()

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Nov 28 16:31:07 UTC 2016


On Thu, Nov 24, 2016 at 08:01:10PM +0200, Jani Nikula wrote:
> On Thu, 24 Nov 2016, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > drm_atomic_crtc_needs_modeset() doesn't change the passed in
> > crtc state, so pass it as const.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>

Pushed to drm-misc-next. Thanks for the review.

> > ---
> >  include/drm/drm_atomic.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
> > index 5d5f85db43f0..d6d241f63b9f 100644
> > --- a/include/drm/drm_atomic.h
> > +++ b/include/drm/drm_atomic.h
> > @@ -418,7 +418,7 @@ int drm_atomic_debugfs_cleanup(struct drm_minor *minor);
> >   * should clear mode_changed during its ->atomic_check.
> >   */
> >  static inline bool
> > -drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state)
> > +drm_atomic_crtc_needs_modeset(const struct drm_crtc_state *state)
> >  {
> >  	return state->mode_changed || state->active_changed ||
> >  	       state->connectors_changed;
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Ville Syrjälä
Intel OTC


More information about the dri-devel mailing list