[PATCH v3 02/13] drm: Fix compilation warning caused by static inline forward declaration

[Daniel Vetter]

On Tue, Nov 29, 2016 at 11:04:32AM +0200, Laurent Pinchart wrote:
> The drm_crtc_mask() function used in <drm/drm_encoder.h> is a static
> inline defined in <drm/drm_crtc.h>. If the first header is included in a
> compilation unit without the second one, the following compilation
> warning will be issued.
> 
> In file included from <linux>/drivers/gpu/drm/drm_bridge.c:29:0:
> <linux>/include/drm/drm_encoder.h:192:95: warning: ‘drm_crtc_mask’ used but never defined
>  static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc);
> 
> Fix this by including the header defining the function instead of using
> a forward declaration.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> ---
>  include/drm/drm_encoder.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h
> index cec6ac45c6cc..5f58f65344e0 100644
> --- a/include/drm/drm_encoder.h
> +++ b/include/drm/drm_encoder.h
> @@ -25,6 +25,7 @@
>  
>  #include <linux/list.h>
>  #include <linux/ctype.h>
> +#include <drm/drm_crtc.h>
>  #include <drm/drm_mode.h>
>  #include <drm/drm_mode_object.h>
>  
> @@ -191,9 +192,6 @@ static inline unsigned int drm_encoder_index(struct drm_encoder *encoder)
>  	return encoder->index;
>  }
>  
> -/* FIXME: We have an include file mess still, drm_crtc.h needs untangling. */
> -static inline uint32_t drm_crtc_mask(const struct drm_crtc *crtc);
> -
>  /**
>   * drm_encoder_crtc_ok - can a given crtc drive a given encoder?
>   * @encoder: encoder to test
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch