[PATCH v3 09/13] drm: Add encoder_type field to the drm_bridge structure

Daniel Vetter daniel at ffwll.ch
Tue Nov 29 10:27:20 UTC 2016


On Tue, Nov 29, 2016 at 11:58:44AM +0200, Laurent Pinchart wrote:
> On Tuesday 29 Nov 2016 10:56:53 Daniel Vetter wrote:
> > On Tue, Nov 29, 2016 at 11:04:39AM +0200, Laurent Pinchart wrote:
> > > The drm_bridge object models on- or off-chip hardware encoders and
> > > provide an abstract control API to display drivers. In order to help
> > > display drivers creating the right kind of drm_encoder object, expose
> > > the type of the hardware encoder associated with each bridge.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas at ideasonboard.com>
> > 
> > DRM_MODE_ENCODER_BRIDGE. Problem solved, because in reality no one cares
> > one iota about the encoder type.
> 
> It's exposed to userspace though, are you 100% sure we won't break anything ?

We've added DP, DSI, DPMST and DPI encoder types thus far, no one
screamed. We should be fine I think. Connector types are a bit different,
userspace (at least X) wants to pretty-print them for xrandr names.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list