[PATCH] drm: Make the connector .detect() callback optional
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Tue Nov 29 21:09:44 UTC 2016
Hi Sean,
On Tuesday 29 Nov 2016 16:07:02 Sean Paul wrote:
> On Tue, Nov 29, 2016 at 3:56 PM, Laurent Pinchart wrote:
> > Many drivers (21 to be exact) create connectors that are always
> > connected (for instance to an LVDS or DSI panel). Instead of forcing
> > them to implement a dummy .detect() handler, make the callback optional
> > and consider the connector as always connected in that case.
>
> I wonder if we should be a little bit smarter about this and default
> connected only for built-in types (LVDS, edp, DSI), and return unknown
> for others?
I've deliberately decided not to change the behaviour of any driver in this
patch to ease review and merge. We can change (a.k.a. improve :-)) the logic
on top of this. Patches are welcome ;-)
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas at ideasonboard.com>
> > ---
> >
> > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 7 -------
> > drivers/gpu/drm/arc/arcpgu_sim.c | 7 -------
> > drivers/gpu/drm/ast/ast_mode.c | 7 -------
> > drivers/gpu/drm/bochs/bochs_kms.c | 7 -------
> > drivers/gpu/drm/bridge/nxp-ptn3460.c | 7 -------
> > drivers/gpu/drm/bridge/parade-ps8622.c | 7 -------
> > drivers/gpu/drm/bridge/tc358767.c | 7 -------
> > drivers/gpu/drm/cirrus/cirrus_mode.c | 7 -------
> > drivers/gpu/drm/drm_probe_helper.c | 14 +++++++++++---
> > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 7 -------
> > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 14 --------------
> > drivers/gpu/drm/gma500/psb_intel_lvds.c | 14 --------------
> > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 -------
> > drivers/gpu/drm/i915/intel_dsi.c | 7 -------
> > drivers/gpu/drm/imx/imx-ldb.c | 7 -------
> > drivers/gpu/drm/imx/imx-tve.c | 7 -------
> > drivers/gpu/drm/imx/parallel-display.c | 7 -------
> > drivers/gpu/drm/mediatek/mtk_dsi.c | 7 -------
> > drivers/gpu/drm/mgag200/mgag200_mode.c | 7 -------
> > drivers/gpu/drm/rcar-du/rcar_du_lvdscon.c | 7 -------
> > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 7 -------
> > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 7 -------
> > drivers/gpu/drm/sti/sti_hda.c | 7 -------
> > drivers/gpu/drm/sun4i/sun4i_rgb.c | 7 -------
> > drivers/gpu/drm/sun4i/sun4i_tv.c | 7 -------
> > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 8 --------
> > include/drm/drm_connector.h | 3 +++
> > 27 files changed, 14 insertions(+), 193 deletions(-)
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list