[PATCH V2] drm: simple_kms_helper: Add prepare_fb and cleanup_fb hooks

Marek Vasut marex at denx.de
Sun Oct 2 16:49:15 UTC 2016


On 09/30/2016 11:58 AM, Daniel Vetter wrote:
> On Thu, Sep 29, 2016 at 11:58 PM, Marek Vasut <marex at denx.de> wrote:
>> +       /**
>> +        * @prepare_fb:
>> +        *
>> +        * Optional, called by struct &drm_plane_helper_funcs ->prepare_fb .
>> +        */
> 
> 
> You've lost the hint that people should look there for what this hook
> should do. Same with cleanup_fb. I think that was useful, can you pls
> reinsert it? Just something like "Please read the documentation for
> the ->prepare_fb hook in &drm_plane_helper_funcs for more details."

OK, added.

-- 
Best regards,
Marek Vasut


More information about the dri-devel mailing list