Regression: drm: Lobotomize set_busid nonsense for !pci drivers (a325725633c2)

Emil Velikov emil.l.velikov at gmail.com
Mon Oct 3 15:00:53 UTC 2016


On 3 October 2016 at 15:27, Laszlo Ersek <lersek at redhat.com> wrote:
[snip]
> the v3 patch accidentally removed the similarly customized set_busid
> callback for amdgpu -- drm_pci_set_busid(). Emil caught that error in
> review, hence the v4 patch wouldn't contain the same error.
>
You're spot on - virtio-gpu doesn't use drm_*platform*_set_busid,
despite that I've misread it as such for over a dozen times. So yes,
that hunk should not have been removed.

Lacking a git checkout on this system, so if anyone beats me to it and
sends a patch that'll be great.

Emil


More information about the dri-devel mailing list