[PATCH] drm: simple_kms_helper: Handle the vblank events

[Marek Vasut]

On 10/03/2016 03:51 PM, Daniel Vetter wrote:
> On Sun, Oct 2, 2016 at 7:15 PM, Marek Vasut <marex at denx.de> wrote:
>>> One thing we could look into for simple pipe helpers is to have a
>>> drm_simple_pipe_state which contains both states, and pass that
>>> simple_state into all callbacks. Needs a bit of trickery in the
>>> atomic_duplicate_state hooks though, so not sure whether that's worth
>>> it. But merging plane/crtc state for simple pipe would be nice, since
>>> the plane/crtc itself are also merged.
>>
>> I took a brief look into this, but I don't think I see the benefit of
>> it. What am I missing here ?
> 
> Well if there's no benefit, then let's not do it - it was just an idea I had.

But I'm a newcomer to DRM/KMS framework, most of the time I barely know
what I'm doing, so it's easily possible I missed something obvious. I
can only think of reducing the number of memory allocations a little,
but I am not convinced this is worth it.

> -Daniel
> 


-- 
Best regards,
Marek Vasut