[PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

Gustavo Padovan gustavo at padovan.org
Wed Oct 5 09:00:03 UTC 2016


Hi Stefan,

2016-10-04 Stefan Christ <contact at stefanchrist.eu>:

> The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> implementations for functions in struct fb_ops. A drm driver can use it
> like:
> 
>     static struct fb_ops drm_fbdev_cma_ops = {
>         .owner          = THIS_MODULE,
>         DRM_FB_HELPER_DEFAULT_OPS,
>         /* driver specific implementations */
>     };
> 
> Suggested-by: Daniel Vetter <daniel at ffwll.ch>
> Signed-off-by: Stefan Christ <contact at stefanchrist.eu>
> ---
> v2: Fix sphinx error:
>      warning: Cannot understand  * @DRM_FB_HELPER_DEFAULT_OPS:
> ---
>  include/drm/drm_fb_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index db8d478..f7d7126 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -214,6 +214,19 @@ struct drm_fb_helper {
>  	bool delayed_hotplug;
>  };
>  
> +/**
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers

If I'm not mistaken v1 of this patch is already in drm-misc so you may
want to send a patch that fix just the line above.

Gustavo


More information about the dri-devel mailing list