[PATCH] drm/bridge: Call drm_connector_cleanup directly

Gustavo Padovan gustavo at padovan.org
Wed Oct 5 14:20:03 UTC 2016


Hi Marek,

2016-10-05 Marek Vasut <marex at denx.de>:

> On 10/05/2016 03:21 PM, Daniel Vetter wrote:
> > On Wed, Oct 05, 2016 at 11:03:20AM +0200, Gustavo Padovan wrote:
> >> Hi Marek,
> >>
> >> 2016-10-05 Marek Vasut <marex at denx.de>:
> >>
> >>> Remove the unnecessary wrapper functions around drm_connector_cleanup().
> >>>
> >>> Signed-off-by: Marek Vasut <marex at denx.de>
> >>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> >>> ---
> >>>  drivers/gpu/drm/bridge/analogix-anx78xx.c | 7 +------
> >>>  drivers/gpu/drm/bridge/nxp-ptn3460.c      | 7 +------
> >>>  drivers/gpu/drm/bridge/parade-ps8622.c    | 7 +------
> >>>  3 files changed, 3 insertions(+), 18 deletions(-)
> >>
> >> Reviewed-by: Gustavo Padovan <gustavo.padovan at collabora.co.uk>
> > 
> > Yeah, nice little cleanup. Applied to drm-misc.
> 
> So while we're at it, I also found drivers with code like [1]. Is
> calling the drm_connector_unregister() necessary in there at all ?
> Or shall we convert it the same way as the three drivers above ?

drm_connector_register/unregister() are not necessary anymore as this is
handled by drm_dev_register() now. So these drivers can be clean up as
well.

Gustavo


More information about the dri-devel mailing list