[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Wed Oct 19 07:54:06 UTC 2016
Hi Jyri,
Thank you for the patch.
On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote:
> Remove obsolete drm_connector_register() call from tda998x_bind(). All
> connectors are registered when drm_dev_register() is called by the
> master drm_device driver.
>
> Signed-off-by: Jyri Sarha <jsarha at ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
By the way, any chance you would plan porting the driver to drm_bridge ? :-)
> ---
> drivers/gpu/drm/i2c/tda998x_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> b/drivers/gpu/drm/i2c/tda998x_drv.c index 9798d40..265f854 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1656,16 +1656,10 @@ static int tda998x_bind(struct device *dev, struct
> device *master, void *data) if (ret)
> goto err_connector;
>
> - ret = drm_connector_register(&priv->connector);
> - if (ret)
> - goto err_sysfs;
> -
> drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder);
>
> return 0;
>
> -err_sysfs:
> - drm_connector_cleanup(&priv->connector);
> err_connector:
> drm_encoder_cleanup(&priv->encoder);
> err_encoder:
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list