[PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

Jean-Francois Moine moinejf at free.fr
Fri Oct 21 17:28:47 UTC 2016


On Thu, 20 Oct 2016 16:56:44 +0530
Archit Taneja <architt at codeaurora.org> wrote:

> > Please show _technically_ how this would work.  I want to see code or
> > pseudo-code illustrating how a "foreign" DRM encoder could be used with
> > either dw-hdmi or tda998x, because right now I can't see any way that
> > could work.
> 
> This is something we already do with the adv7511 bridge driver on msm,
> rcar and arc (for 4.9) drivers.
> 
> I've shared pseudo code on the kms driver and encoder chip's driver
> side. I've also shared a diff that converts the tda998x driver to use
> drm_bridge(uncompiled/untested).
> 
> 1) Kms driver side:
> 
> /*
>   * Create an encoder instance. Depending on the hardware represented
>   * by the KMS driver, the encoder can ops can either have some
>   * functionality, or be nops. In the case of tilcdc, the encoder
>   * funcs would be mostly nops.
>   */
> drm_encoder_helper_add(&kms_priv->encoder, &kms_encoder_helper_funcs);
> drm_encoder_init(kms_pirv->drm, &kms_priv->encoder, &kms_encoder_funcs,
> 		 type, NULL);

Then, how does this 'kms_priv' know the type of the encoder, this one
being tied to the connector type at the end of the bridge chain?

-- 
Ken ar c'hentaƱ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/


More information about the dri-devel mailing list