[PATCH 0/6] Rebase of David Herrmann drm connector link to backlight device

Marta Lofstedt marta.lofstedt at intel.com
Mon Oct 24 13:08:47 UTC 2016


Hi David,

I am currently investigating:
https://bugs.freedesktop.org/show_bug.cgi?id=96572

Martin Peres suggested that your patches:
https://lists.freedesktop.org/archives/dri-devel/2014-September/thread.html#67984
could solve the xf86-video-modesetting backlight issues.

I have rebased your patches and I am working on an IGT
test for the functionality. With my i915 implementation
and the small included bug-fix, I can update the drm BACKLIGHT
property and the value is updated in the backlight class device.
However, if I set the brigness value through the sysfs file of
the backlight class device the drm BRIGHTNESS property does not
update which would be confusing to users.

My understanding is that DRM properties are cached and, by design,
do not have the capability to read the status from the driver.

What do we want to do about this?

Marta

David Herrmann (4):
  backlight: use static initializers
  backlight: use spin-lock to protect device list
  backlight: add kernel-internal backlight API
  drm: link connectors to backlight devices

Marta Lofstedt (2):
  i915: Use drm backlight
  drm: drm_backlight use the connect value to set brightness property

 drivers/gpu/drm/Kconfig             |   1 +
 drivers/gpu/drm/Makefile            |   2 +-
 drivers/gpu/drm/drm_backlight.c     | 387 ++++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/drm_connector.c     |  11 +
 drivers/gpu/drm/drm_crtc.c          |   6 +
 drivers/gpu/drm/drm_drv.c           |   8 +
 drivers/gpu/drm/drm_sysfs.c         |  54 +++++
 drivers/gpu/drm/i915/intel_panel.c  |   5 +
 drivers/video/backlight/backlight.c |  91 +++++++--
 include/drm/drm_backlight.h         |  44 ++++
 include/drm/drm_connector.h         |   3 +
 include/drm/drm_crtc.h              |   5 +
 include/linux/backlight.h           |  17 ++
 13 files changed, 621 insertions(+), 13 deletions(-)
 create mode 100644 drivers/gpu/drm/drm_backlight.c
 create mode 100644 include/drm/drm_backlight.h

-- 
2.9.3



More information about the dri-devel mailing list