[PATCH] drm/amd/powerplay: mark symbols static where possible

[Baoyou Xie]

On 25 October 2016 at 04:51, Arnd Bergmann <arnd at arndb.de> wrote:

> On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> > @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr)
> >         return result;
> >  }
> >
> > -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> > +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> >  {
> >
> >         return 0;
> >
>
> This needs to be done differently:
>
> ../drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1344:12:
> error: 'smu7_reset_asic_tasks' defined but not used
> [-Werror=unused-function]
>
> The function has no callers, so the easiest way would be to remove it
> entirely, but it's possible that there are plans to add users soon.
>
> It was assumed that this function will be used soon, so this patch remains
it.
if it still not be used in 4.10, then we can remove it.
is it right?


>         Arnd
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20161025/9d0d6ea4/attachment.html>