[PATCH 04/20] drm/ast: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops

[Daniel Vetter]

On Thu, Sep 29, 2016 at 10:48:40PM +0200, Stefan Christ wrote:
> Cc: Dave Airlie <airlied at redhat.com>
> Signed-off-by: Stefan Christ <contact at stefanchrist.eu>
> ---
>  drivers/gpu/drm/ast/ast_fb.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
> index c017a93..b604fdd 100644
> --- a/drivers/gpu/drm/ast/ast_fb.c
> +++ b/drivers/gpu/drm/ast/ast_fb.c
> @@ -150,14 +150,10 @@ static void ast_imageblit(struct fb_info *info,
>  
>  static struct fb_ops astfb_ops = {
>  	.owner = THIS_MODULE,
> -	.fb_check_var = drm_fb_helper_check_var,
> -	.fb_set_par = drm_fb_helper_set_par,
> +	DRM_FB_HELPER_DEFAULT_OPS,
>  	.fb_fillrect = ast_fillrect,
>  	.fb_copyarea = ast_copyarea,
>  	.fb_imageblit = ast_imageblit,

Ah, here's the likely reason for not sharing these, ast/cirrus have their
special dirtying stuff for fbdev emulation. And because the fbdev mmap
must have a stable pointer it can't use the ttm bo mmap magic of
automatically picking the right place for the mmap.

I'd say just leave these 2 drivers out as special cases.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch