[Bug 178421] [regression] Radeon Oops on shutdown

[bugzilla-daemon at bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=178421

Jouni Mettälä <jtmettala at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Regression|No                          |Yes

--- Comment #6 from Jouni Mettälä <jtmettala at gmail.com> ---
With patches referenced in comment 1, bisect pointed to
6b25e21fa6f26d0f0d45f161d169029411c84286
Merge tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux

I was still bit unsure but after removing these shutdown seems to work.

@@ -362,6 +361,17 @@ radeon_pci_remove(struct pci_dev *pdev)
     drm_put_dev(dev);
 }

+static void
+radeon_pci_shutdown(struct pci_dev *pdev)
+{
+    /* if we are running in a VM, make sure the device
+     * torn down properly on reboot/shutdown.
+     * unfortunately we can't detect certain
+     * hypervisors so just do this all the time.
+     */
+    radeon_pci_remove(pdev);
+}
+
 static int radeon_pmops_suspend(struct device *dev)
 {
     struct pci_dev *pdev = to_pci_dev(dev);


@@ -574,6 +588,7 @@ static struct pci_driver radeon_kms_pci_driver = {
     .id_table = pciidlist,
     .probe = radeon_pci_probe,
     .remove = radeon_pci_remove,
+    .shutdown = radeon_pci_shutdown,
     .driver.pm = &radeon_pm_ops,
 };

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/drivers/gpu/drm/radeon/radeon_drv.c?id=6b25e21fa6f26d0f0d45f161d169029411c84286

During bisect some kernels failed to boot with initrd and UUID. Without initrd
they booted but still didn't shutdown.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.