[PATCH libdrm] add libsync.h helper

Emil Velikov emil.l.velikov at gmail.com
Mon Oct 31 15:25:00 UTC 2016


On 31 October 2016 at 13:44, Rob Clark <robdclark at gmail.com> wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> Rather than cut/pasting these couple ioctl wrappers everywhere, just
> stuff them as static-inline into a header.
>
> Signed-off-by: Rob Clark <robclark at freedesktop.org>
> ---
> This is probably mostly used from mesa, but some drivers, test apps, etc
> may also want to use it from libdrm.
>
It makes sense imho. To avoid fun experiences we want the header
synced in an identical manner (make headers_install) to the
include/drm ones. One might as well move it there, so make its "more"
obvious.


> +static inline int sync_wait(int fd, int timeout)
> +{
> +       struct pollfd fds;
> +
> +       fds.fd = fd;
> +       fds.events = POLLIN | POLLERR;
IIRC the API does not mention (forbid even) additional members of the
pollfd struct.
Let's zero init fds, and the compiler will drop it if/where applicable ?

Thanks
Emil


More information about the dri-devel mailing list