[PATCH v2 5/5] drm/tilcdc: WARN if CRTC is touched without CRTC lock

Tomi Valkeinen tomi.valkeinen at ti.com
Wed Sep 7 08:09:53 UTC 2016


On 06/09/16 23:59, Jyri Sarha wrote:
> WARN if CRTC is touched without CRTC lock. The crtc functions should
> not be called simultaneously from multiple threads. Having the DRM
> CRTC lock should take care of that.
> 
> tilcdc_crtc_destroy() has to take the CRTC lock befor calling
> tilcdc_crtc_disable() because drm_mode_config_cleanup() does not take
> the lock. If this ever changes the CRTC locking has to be removed from
> tilcdc_crtc_destroy().

Shouldn't these be two separate patches? This one is (according to
subject) adding WARNs, but it is actually also adding locking.

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160907/aa74092c/attachment.sig>


More information about the dri-devel mailing list