[PATCH 3/4] drm/fsl-dcu: update all registers on flush
Meng Yi
meng.yi at nxp.com
Wed Sep 7 08:46:32 UTC 2016
Hi Stefan,
Some comments below
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-
> dcu/fsl_dcu_drm_crtc.c
> index d30b61e..62eb284 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
> @@ -27,6 +27,9 @@ static void fsl_dcu_drm_crtc_atomic_flush(struct drm_crtc
> *crtc, {
> struct drm_pending_vblank_event *event = crtc->state->event;
>
> + regmap_write(fsl_dev->regmap,
> + DCU_UPDATE_MODE, DCU_UPDATE_MODE_READREG);
fsl_dev is not declared.
I had added these two lines when testing the patches.
struct drm_device *dev = crtc->dev;
struct fsl_dcu_drm_device *fsl_dev = dev->dev_private;
> +
> if (event) {
> crtc->state->event = NULL;
>
Best Regards,
Meng
More information about the dri-devel
mailing list