[PATCH] drm/udl: Fix for the X server screen update v2

Daniel Vetter daniel.vetter at ffwll.ch
Mon Sep 19 21:12:06 UTC 2016


On Mon, Sep 19, 2016 at 8:27 PM, poma <pomidorabelisima at gmail.com> wrote:
> @@ -122,14 +126,14 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y,
>                 return 0;
>         cmd = urb->transfer_buffer;
>
> -       for (i = y; i < height ; i++) {
> +       for (i = y; i <= y2 ; i++) {

I think a simpler fix (which retains Noralf's nice cleanup would be to
change the loop condition to i < y + height. At least that seems to be
the underlying bug. Can you pls test that and then submit either that
one-liner (if it works) or your original patch (it's missing the
signed-off-by right now, so can't be merged as-is)? Either one has my
r-b (preemptive since I'm travelling).

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list