[PATCH v3 06/20] drm: omapdrm: Handle FIFO underflow IRQs internally

[Tomi Valkeinen]

On 19/09/16 15:27, Laurent Pinchart wrote:
> As the FIFO underflow IRQ handler just prints an error message to the
> kernel log, simplify the code by not registering one IRQ handler per
> plane but print the messages directly from the main IRQ handler.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> Changes since v1:
> 
> - Only register error IRQs that exist on the HW
> ---


> +static const u32 error_irqs[] = {
> +	[OMAP_DSS_GFX] = DISPC_IRQ_GFX_FIFO_UNDERFLOW,
> +	[OMAP_DSS_VIDEO1] = DISPC_IRQ_VID1_FIFO_UNDERFLOW,
> +	[OMAP_DSS_VIDEO2] = DISPC_IRQ_VID2_FIFO_UNDERFLOW,
> +	[OMAP_DSS_VIDEO3] = DISPC_IRQ_VID3_FIFO_UNDERFLOW,
> +};

Actually, one comment: "error_irqs" is perhaps not a good name for this.
"omap_underflow_irqs"?

Or actually, maybe it would make sense to move this into dispc, and have
a similar func to dispc_mgr_get_sync_lost_irq().

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20160920/7411a729/attachment-0001.sig>