[PATCH] drm/tilcdc: mark tilcdc_atomic_check() static

Jyri Sarha jsarha at ti.com
Thu Sep 22 16:01:44 UTC 2016


Thank,
But I already have this too:
http://www.spinics.net/lists/kernel/msg2340400.html

Best regards,
Jyri

On 09/21/16 08:14, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie at linaro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..1d26bc9 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,7 +61,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
>  	drm_fbdev_cma_hotplug_event(priv->fbdev);
>  }
>  
> -int tilcdc_atomic_check(struct drm_device *dev,
> +static int tilcdc_atomic_check(struct drm_device *dev,
>  			struct drm_atomic_state *state)
>  {
>  	int ret;
> 



More information about the dri-devel mailing list