[PATCH 1/2] dt-bindings: mxsfb: Add bindings for the MXSFB KMS/DRM driver

[Marek Vasut]

On 09/02/2016 02:30 PM, Rob Herring wrote:
> On Fri, Aug 26, 2016 at 04:27:41PM +0200, Marek Vasut wrote:
>> Add DT bindings for new MXSFB driver using the DRM framework.
>> The old MXSFB fbdev driver bindings are preserved in mxsfb.txt .

Sorry for the late reply.

> They should be documented in the same place as they describe the same 
> h/w. I've not looked how incompatible they are, but I'd expect that to 
> be described here.

Done, makes sense.

>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: devicetree at vger.kernel.org
>> Cc: Rob Herring <robh at kernel.org>
>> Cc: Lucas Stach <l.stach at pengutronix.de>
>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>> Cc: Shawn Guo <shawnguo at kernel.org>
>> ---
>>  .../devicetree/bindings/display/mxsfb-drm.txt      | 33 ++++++++++++++++++++++
> 
> DRM is a Linuxism.
> 
>>  1 file changed, 33 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/display/mxsfb-drm.txt
>>
>> diff --git a/Documentation/devicetree/bindings/display/mxsfb-drm.txt b/Documentation/devicetree/bindings/display/mxsfb-drm.txt
>> new file mode 100644
>> index 0000000..e70d337
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/mxsfb-drm.txt
>> @@ -0,0 +1,33 @@
>> +* Freescale MXS LCD Interface (LCDIF) with KMS/DRM support
> 
> KMS/DRM is a Linuxism.

So what do you put in the documentation instead, "driver using of graph" ?

>> +
>> +Required properties:
>> +- compatible:	Should be "fsl,imx23-lcdif" for i.MX23.
>> +		Should be "fsl,imx28-lcdif" for i.MX28 and i.MX6SX.
> 
> MX6SX should have it's own compatible string. Knowing some of the 
> development history, I would doubt they are exactly the same.
> 
> Also, IIRC MX50 variants have LCDIF.

OK, done.

>> +- reg:		Address and length of the register set for lcdif
>> +- interrupts:	Should contain lcdif interrupts
>> +- clocks:	A list of phandle + clock-specifier pairs, one for each
>> +		entry in 'clock-names'.
>> +- clock-names:	A list of clock names. For MXSFB it should contain:
>> +    - "pix" for the MXSFB block clock
>> +    - (optional) "axi", "disp_axi" for the bus interface clock on MX6SX
> 
> Doesn't this mean required on MX6SX?

Yes, it does, fixed.

>> +
>> +Required sub-nodes:
>> +  - port: The connection to an encoder chip.
>> +
>> +Example:
>> +
>> +	lcdif1: lcdif at 02220000 {
> 
> Drop the leading 0.

OK

>> +		compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>> +		reg = <0x02220000 0x4000>;
>> +		interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
>> +			 <&clks IMX6SX_CLK_LCDIF_APB>,
>> +			 <&clks IMX6SX_CLK_DISPLAY_AXI>;
>> +		clock-names = "pix", "axi", "disp_axi";
>> +
>> +		port {
>> +			parallel_out: endpoint {
>> +				remote-endpoint = <&panel_in_parallel>;
>> +			};
>> +		};
>> +	};
>> -- 
>> 2.9.3
>>


-- 
Best regards,
Marek Vasut