[RFC PATCH 1/6] drm: add helper for arming crtc completion event

Daniel Vetter daniel at ffwll.ch
Thu Sep 29 14:24:47 UTC 2016


On Thu, Sep 29, 2016 at 3:39 PM, Andrzej Hajda <a.hajda at samsung.com> wrote:
>
>>> +                    drm_crtc_arm_vblank_event(crtc, event);
>>> +            else
>>> +                    drm_crtc_send_vblank_event(crtc, event);
>>> +            spin_unlock_irq(&crtc->dev->event_lock);
>>> +    }
>>> +}
>>> +EXPORT_SYMBOL(drm_crtc_arm_completion_event);
>> Maybe we need an EXPORT_SYMBOL_BROKEN for this .... btw the kerneldoc of
>> the functions you're called do explain that this is not as easy as it
>> seems. That's also something you throw under the rug here.
>> -Daniel
>
> After quick look I have not found these kerneldocs, where can read about it.

Oops, it's indeed not there. It should be right next to
arm_vblank_event as a real big warning, but looks like I only put that
in some commit message and not into the docs itself :( Will fix asap.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dri-devel mailing list