[PATCH 6/6] drm/amdgpu: handle CPU access for split VRAM buffers
Christian König
deathsimple at vodafone.de
Tue Apr 4 11:30:10 UTC 2017
Am 03.04.2017 um 18:25 schrieb Nicolai Hähnle:
> On 31.03.2017 11:47, Christian König wrote:
>> From: Christian König <christian.koenig at amd.com>
>> [SNIP]
>> mem->bus.offset = mem->start << PAGE_SHIFT;
>> /* check if it's visible */
>> if ((mem->bus.offset + mem->bus.size) >
>> adev->mc.visible_vram_size)
>
> I believe the various mem->bus members are now unused, aren't they?
> Unless I missed something, it's best to clean this up and no longer
> set them (or set them to some obvious poison values).
No, they are still needed for in kernel mappings. I only handle split
mappings from userspace with the new callback.
Regards,
Christian.
More information about the dri-devel
mailing list